From 7603ccd22d447e1e778f3a4a8c131be0064ac989 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stefan=20Tollk=C3=BChn?= <s.tollkuehn@bnvb-ingenieure.de>
Date: Wed, 23 Jul 2025 13:11:11 +0200
Subject: [PATCH] use a more DRY way to build project view

---
 app/helpers/projects_helper.rb       |  4 ++++
 app/views/projects/_project.html.erb | 11 +++++++----
 config/routes.rb                     |  1 -
 3 files changed, 11 insertions(+), 5 deletions(-)

diff --git a/app/helpers/projects_helper.rb b/app/helpers/projects_helper.rb
index 1fa71ec..7548c64 100644
--- a/app/helpers/projects_helper.rb
+++ b/app/helpers/projects_helper.rb
@@ -2,4 +2,8 @@ module ProjectsHelper
   def project_form_fields
     [:name, :email, :short_name, :offer_date, :order_date]
   end
+
+  def project_view_fields
+    [:name, :email, :short_name, :offer_date, :order_date]
+  end
 end
\ No newline at end of file
diff --git a/app/views/projects/_project.html.erb b/app/views/projects/_project.html.erb
index 7facf54..c68459d 100644
--- a/app/views/projects/_project.html.erb
+++ b/app/views/projects/_project.html.erb
@@ -1,8 +1,11 @@
 <div id="<%= dom_id project %>">
-  <p>
-    <strong>Name:</strong>
-    <%= project.email %> <%= project.name %>
-  </p>
+  <% project_view_fields.each do |attrib| %>
+    <p>
+      <strong><%= attrib.to_s.humanize %>:</strong>
+      <%= value = project.send(attrib) %>
+      <%= value.is_a?(Date) ? l(value) : value %>
+    </p>
+  <% end %>
 
   <% if project.subprojects.any? %>
     <ul>
diff --git a/config/routes.rb b/config/routes.rb
index 3660f6d..115640c 100644
--- a/config/routes.rb
+++ b/config/routes.rb
@@ -1,7 +1,6 @@
 Rails.application.routes.draw do
   resources :clients
   resources :subprojects
-  resources :subprojects
   resources :subproject_addresses
   resources :projects
   # Define your application routes per the DSL in https://guides.rubyonrails.org/routing.html